Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healthcheck: account for custom bind port #295

Merged
merged 1 commit into from
May 24, 2023

Conversation

djarbz
Copy link
Contributor

@djarbz djarbz commented Jan 4, 2023

Update HEALTHCHECK to account when a custom BIND_ADDRESS is set, defaulting to port 5000

@bytedream
Copy link
Contributor

There is also an issue that the healthcheck doesn't work when a custom $BASE_PATH is set (#320). You could address the issue in this PR too, so that no extra PR has to be made for it.

@stale
Copy link

stale bot commented May 1, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 1, 2023
@djarbz
Copy link
Contributor Author

djarbz commented May 1, 2023

Bump

@stale stale bot removed the stale label May 1, 2023
@ngoduykhanh ngoduykhanh merged commit 5913332 into ngoduykhanh:master May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants