Add PartyChanged event #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 27, 2019
quisquous
added a commit
to quisquous/cactbot
that referenced
this pull request
Oct 27, 2019
This fixes #570. This depends on ngld/OverlayPlugin#17
|
Thanks! The detailed comments are very nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new event for party changed. Because the partySize is probably confusing (see comments in the patch), it's not provided as part of the event. Just getting the length of the party is good enough to know when you are in 8 or 24 person content.
This handler doesn't use any of the parameters given to it, so can also be called manually to send initial data.