Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing wasm-wasi-component test #1477

Closed
javorszky opened this issue Oct 24, 2024 · 7 comments
Closed

Fix failing wasm-wasi-component test #1477

javorszky opened this issue Oct 24, 2024 · 7 comments
Assignees

Comments

@javorszky
Copy link
Contributor

The wasm-wasi-component test keeps failing for no apparent reason. This is an issue to track that we're working on it.

@javorszky javorszky self-assigned this Oct 24, 2024
@ac000
Copy link
Member

ac000 commented Oct 24, 2024

Was looking at this last night.

The test runs fine on Fedora 40. Fails on Ubuntu 24.04.

This thing seems generally pretty fragile...

@ac000
Copy link
Member

ac000 commented Oct 24, 2024

The pytest wasm-wasi-component built on Ubuntu 24.04 does run under wasmtime v24 (on Fedora at least)

@callahad
Copy link
Collaborator

@ac000 If you have any other notes, might be worth dropping them here. I'll let @javorszky run with this as the assignee.

@ac000
Copy link
Member

ac000 commented Oct 29, 2024

The hello_world component built under Ubuntu 24.04 does not run under Unit on Fedora either. Same error I beleive

2024/10/29 03:31:00 [alert] 490364#490364 failed to create initial state

Caused by:
    0: failed to compile component
    1: WebAssembly translation error
    2: Invalid input WebAssembly code at offset 15939: zero byte expected

@ac000
Copy link
Member

ac000 commented Nov 6, 2024

Now that I'm on Fedora 41, it's broken here also... (from pytests)

2024/11/06 21:08:50 [alert] 107196#107196 failed to create initial state

Caused by:
    0: failed to compile component
    1: WebAssembly translation error
    2: Invalid input WebAssembly code at offset 15936: zero byte expected

@ac000
Copy link
Member

ac000 commented Nov 6, 2024

Looks like we may be hitting this bytecodealliance/wasmtime#9130

Enabling the gc feature fixes it on Fedora 41, I'll test it on the GH stuff...

@ac000
Copy link
Member

ac000 commented Nov 6, 2024

I wonder if we can just move to wasmtime 26.0.1...

Seems like it...

ac000 added a commit to ac000/unit that referenced this issue Nov 6, 2024
This fixes an issue we had with wasm-wasi-component failing to load
components with

  2024/11/06 21:08:50 [alert] 107196#107196 failed to create initial state

  Caused by:
      0: failed to compile component
      1: WebAssembly translation error
      2: Invalid input WebAssembly code at offset 15936: zero byte expected

Which was a symptom of
<bytecodealliance/wasmtime#9130>

Closes: nginx#1477
Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
@ac000 ac000 closed this as completed in e6519b9 Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants