Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove field name decapitalization in the scheme #33

Closed
pleshakov opened this issue Mar 5, 2024 · 1 comment
Closed

Remove field name decapitalization in the scheme #33

pleshakov opened this issue Mar 5, 2024 · 1 comment
Milestone
v0.1.0

Comments

@pleshakov
Copy link
Contributor

For consistency with DataFabric examples, we make field names start
with lowercase letter. As a result, we convert the first character
of field name in a go struct to lowercase. For example,
MyField -> myField. However, the generated scheme names for fields
like HTTPRoutes look a bit ugly: HTTPRoutes -> hTTPRoutes

Acceptance criteria:

  • Remove decapitalization
pleshakov added a commit that referenced this issue Mar 5, 2024
@pleshakov
Remove field name decapitalization in the scheme
043d2c3 
Problem:

For consistency with DataFabric examples, we make field names start
with lowercase letter. As a result, we convert the first character
of field name in a go struct to lowercase. For example,
MyField -> myField. However, the generated scheme names for fields
like HTTPRoutes look a bit ugly: HTTPRoutes -> hTTPRoutes

Solution:

This is not a hard requirement for Avro scheme, we can use names like
HTTPRoutes just fine.

long? HTTPRoutes = null;

CLOSES -- #33
@pleshakov pleshakov mentioned this issue Mar 5, 2024
Merged
6 tasks
pleshakov added a commit that referenced this issue Mar 6, 2024
@pleshakov
Remove field name decapitalization in the scheme (#34)
f5b0474 
Problem:

For consistency with DataFabric examples, we make field names start
with lowercase letter. As a result, we convert the first character
of field name in a go struct to lowercase. For example,
MyField -> myField. However, the generated scheme names for fields
like HTTPRoutes look a bit ugly: HTTPRoutes -> hTTPRoutes

Solution:

This is not a hard requirement for Avro scheme, we can use names like
HTTPRoutes just fine.

long? HTTPRoutes = null;

CLOSES -- #33
@pleshakov
Copy link
Contributor Author

Fixed by #34

@lucacome lucacome added this to the v0.1.0 milestone Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.0
Development

No branches or pull requests
2 participants
@lucacome @pleshakov