Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update from nginxinc to nginx #943

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Update from nginxinc to nginx #943

merged 1 commit into from
Jan 9, 2025

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Jan 9, 2025

Proposed changes

Updates all the references to nginxinc

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

@lucacome lucacome requested a review from a team January 9, 2025 03:22
@github-actions github-actions bot added documentation Pull requests/issues for documentation dependencies Pull requests that update a dependency file chore Pull requests for routine tasks labels Jan 9, 2025
pdabelf5
pdabelf5 reviewed Jan 9, 2025
View reviewed changes
README.md Show resolved Hide resolved
salonichf5
salonichf5 approved these changes Jan 9, 2025
View reviewed changes
Copy link

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lucacome lucacome merged commit 8da901c into main Jan 9, 2025
13 checks passed
@lucacome lucacome deleted the chore/nginx branch January 9, 2025 23:49
@lucacome lucacome added this to the 1.4.1 milestone Jan 10, 2025
@github-actions github-actions bot mentioned this pull request Jan 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 left review comments

@salonichf5 salonichf5 salonichf5 approved these changes

@bjee19 bjee19 bjee19 approved these changes

@sjberman sjberman sjberman approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks dependencies Pull requests that update a dependency file documentation Pull requests/issues for documentation
Projects
None yet
Milestone
v1.4.1
Development

Successfully merging this pull request may close these issues.
5 participants
@lucacome @sjberman @pdabelf5 @bjee19 @salonichf5