Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OIDC to login to AWS #407

Merged
merged 1 commit into from
May 5, 2023
Merged

Use OIDC to login to AWS #407

merged 1 commit into from
May 5, 2023

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented May 5, 2023

Proposed changes

This PR updates the workflows to use OIDC to log in to AWS using short-lived tokens instead of static keys.

From the docs:

OpenID Connect (OIDC) allows your GitHub Actions workflows to access resources in Amazon Web Services (AWS), without needing to store the AWS credentials as long-lived GitHub secrets.

@lucacome lucacome requested a review from a team as a code owner May 5, 2023 21:32
@lucacome lucacome self-assigned this May 5, 2023
@github-actions github-actions bot added the chore Pull requests for routine tasks label May 5, 2023
jasonwilliams14
jasonwilliams14 approved these changes May 5, 2023
View reviewed changes
Copy link

@jasonwilliams14 jasonwilliams14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@lucacome lucacome merged commit d4f86ef into main May 5, 2023
@lucacome lucacome deleted the chore/oidc-login-aws branch May 5, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonwilliams14 jasonwilliams14 jasonwilliams14 approved these changes

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucacome @jasonwilliams14