Add k8s object labels to tcp metrics #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorcanMcVeigh
requested review from
lucacome,
mikestephen,
pleshakov and
Dean-Coakley
mikestephen
reviewed
Nov 19, 2020
mikestephen
reviewed
Nov 19, 2020
| @@ -59,6 +66,24 @@ func (c *NginxPlusCollector) DeleteUpstreamServerPeerLabels(peers []string) { | |||
| c.variableLabelsMutex.Unlock() | |||
| } | |||
|
|
|||
| // UpdateStreamUpstreamServerPeerLabels updates the Upstream Server Peer Labels | |||
| func (c *NginxPlusCollector) UpdateStreamUpstreamServerPeerLabels(streamUpstreamServerPeerLabels map[string][]string) { | |||
| c.variableLabelsMutex.Lock() | |||
There was a problem hiding this comment.
Why use a mutex here? Can this be called from multiple goroutines?
mikestephen
approved these changes
Nov 19, 2020
Co-authored-by: Dean Coakley <dean.s.coakley@gmail.com>
Dean-Coakley
approved these changes
Nov 25, 2020
lucacome
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add k8s object labels to tcp metrics
Checklist
Before creating a PR, run through this checklist and mark each as complete.