Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same style of release names as official exporters #125

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Use same style of release names as official exporters #125

merged 1 commit into from
Oct 7, 2020

Conversation

Perflyst
Copy link
Contributor

@Perflyst Perflyst commented Oct 2, 2020

Proposed changes

The official prometheus exporters use all the same naming scheme. You used a - instead of a . for whatever reason.
To make it easier to download exporters, in standardized ways, it would be good if everyone follows this schema.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch on my own fork

@LorcanMcVeigh
Copy link
Contributor

LorcanMcVeigh commented Oct 6, 2020

Hey @Perflyst

Thanks for the PR. This looks good to me and makes sense

we typically get 2 people to approve before merging, so just let the other guys take a look at it first before merging.

@lucacome lucacome merged commit d97be01 into nginx:master Oct 7, 2020
@lucacome lucacome added enhancement Pull requests for new features/feature enhancements minor labels Feb 19, 2021
@rosaLux161
Copy link

Good for some, bad for others. If the script aborts when updating the version number because the naming structure has changed. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants