Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default prometheus datasource was not found error #111

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

mobeigi
Copy link
Contributor

@mobeigi mobeigi commented Jul 13, 2020

Proposed changes

When using this Grafana dashboard, we get the following error: Datasource named ${DS_PROMETHEUS} was not found. This change fixes this issue.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • [ X ] I have read the CONTRIBUTING guide
  • [ X ] I have proven my fix is effective or that my feature works
  • [ X ] I have checked that all unit tests pass after adding my changes
  • [ X ] I have ensured the README is up to date
  • [ X ] I have rebased my branch onto master
  • [ X ] I will ensure my PR is targeting the master branch and pulling from my branch on my own fork

@Rulox
Copy link

Rulox commented Jul 14, 2020

Thanks @mobeigi

We'll have a look at this ASAP and get back to you

@Rulox Rulox self-requested a review July 14, 2020 16:54
@Rulox Rulox added the bug An issue reporting a potential bug label Jul 14, 2020
Copy link

@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've had a look, it seems is a common error that happens when this is not defined. Same error in other repos is fixed in the same way:

https://github.com/kubernetes/ingress-nginx/pull/4797/files

I've tested it and it looks good to me.

Once you get 2 approvals, could you squash your 2 commits into one?, After that I'll make sure to merge it. Thanks

@mobeigi mobeigi force-pushed the fix-default-prometheus-not-found branch from afc3b5e to 311947a Compare July 17, 2020 15:14
@mobeigi
Copy link
Contributor Author

mobeigi commented Jul 17, 2020

@Rulox Squashed the commits 😄

@Dean-Coakley Dean-Coakley merged commit 1d070f2 into nginx:master Jul 17, 2020
@Dean-Coakley
Copy link
Contributor

@mobeigi Thanks a lot for this fix!

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants