-
Notifications
You must be signed in to change notification settings - Fork 130
Add control/data plane HPA #3702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Problem: I want the NGF control plane and nginx data plane to scale automatically based on resource consumption or other metrics. Solution: Allow for configuring a HorizontalPodAutoscaler (HPA) through the helm chart and NginxProxy resource for both Deployments.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3702 +/- ##
==========================================
- Coverage 87.14% 87.05% -0.09%
==========================================
Files 128 128
Lines 15779 15919 +140
Branches 62 62
==========================================
+ Hits 13750 13858 +108
- Misses 1869 1896 +27
- Partials 160 165 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Do we need to clean up HPA if the autoscaling is removed from NginxProxy? |
Yeah we should. Gonna need to add logic for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One non-blocking question, otherwise looks great! 🎉
Problem: I want the NGF control plane and nginx data plane to scale automatically based on resource consumption or other metrics.
Solution: Allow for configuring a HorizontalPodAutoscaler (HPA) through the helm chart and NginxProxy resource for both Deployments.
Testing: Verified that the HPA works for both Deployments.
Closes #3447
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.