move ks client reader to separated directory

[miledxz]

Proposed changes

Problem: Adding update of ks client Reader interface and FakeReader into separated directory.

Solution: Moved files, updated import paths.

Closes #1573

Before creating a PR, run through this checklist and mark each as complete.

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have checked that all unit tests pass after adding my changes
• I have updated necessary documentation
• I have rebased my branch onto main
• I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

[github-actions]

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
_{Posted by the CLA Assistant Lite bot.}

[miledxz]

I have hereby read the F5 CLA and agree to its terms

[kate-osborn]

@miledxz changes look good, but it looks like the eventsfakes directory hasn't been deleted. Can you delete it?

[miledxz]

@miledxz changes look good, but it looks like the eventsfakes directory hasn't been deleted. Can you delete it?

Hi @kate-osborn, in eventsfakes dir are other fake mocks like FakeEventHandler and FakeFirstEventBatchPreparer
defined here https://github.com/nginx/nginx-gateway-fabric/blob/main/internal/framework/events/handler.go#L9
and here https://github.com/nginx/nginx-gateway-fabric/blob/main/internal/framework/events/first_eventbatch_preparer.go#L14,

do we need to keep them ? because of other tests

[kate-osborn]

@miledxz changes look good, but it looks like the eventsfakes directory hasn't been deleted. Can you delete it?

Hi @kate-osborn, in eventsfakes dir are other fake mocks like FakeEventHandler and FakeFirstEventBatchPreparer defined here https://github.com/nginx/nginx-gateway-fabric/blob/main/internal/framework/events/handler.go#L9 and here https://github.com/nginx/nginx-gateway-fabric/blob/main/internal/framework/events/first_eventbatch_preparer.go#L14,

do we need to keep them ? because of other tests

ahh, I see! I didn't check for other fakes in that directory. All good, then.

[miledxz]

@miledxz changes look good, but it looks like the eventsfakes directory hasn't been deleted. Can you delete it?

Hi @kate-osborn, in eventsfakes dir are other fake mocks like FakeEventHandler and FakeFirstEventBatchPreparer defined here https://github.com/nginx/nginx-gateway-fabric/blob/main/internal/framework/events/handler.go#L9 and here https://github.com/nginx/nginx-gateway-fabric/blob/main/internal/framework/events/first_eventbatch_preparer.go#L14,
do we need to keep them ? because of other tests

ahh, I see! I didn't check for other fakes in that directory. All good, then.

sounds like a plan !

[kate-osborn]

LGTM!