-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Graceful Recovery Baseline Test #1111
Conversation
Would like specific feedback on the last two test cases.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Very thorough instructions 👍
Can you create a directory under tests
for this test? I know there's only one file, but I think it will be good to match the structure of the other testing PRs.
See my review for a few comments and suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bjee19 Please see a few major and minor requests and comments.
Big one - let's use SIGKILL
because SIGTERM
kicks in graceful, not abrupt (failure), termination.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff 👍
aa6255b
to
95f8157
Compare
Add Graceful Recovery Baseline Test Problem: We want to have a test that checks for how well NGF recovers from container failures. Solution: Added manual tests that checked for when the nginx-gateway container restarted, when the NGINX container restarted, when we drained a node then restarted it, and when we didn't drain a node then restarted it.
Proposed changes
Problem: We want to have a test that checks for how well NGF recovers from container failures.
Solution: Added a manual test that checks for when the nginx-gateway container fails, when the nginx container fails, when the NGF Pod restarts due to a node restart with cleaning up of resources, and when the NGF Pod restarts due to a node restart without cleaning up of resources.
Closes #951
Checklist
Before creating a PR, run through this checklist and mark each as complete.