Update vs/vsr status when IC becomes the leader #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rulox
requested review from
lucacome,
pleshakov,
Dean-Coakley,
LorcanMcVeigh and
vepatel
LorcanMcVeigh
approved these changes
Jun 17, 2020
pleshakov
suggested changes
Jun 19, 2020
|
I've implemented your suggestions @pleshakov @LorcanMcVeigh let me know your thoughts, thanks |
pleshakov
suggested changes
Jun 22, 2020
There was a problem hiding this comment.
@Rulox thanks for the updates.
The new code doesn't compile ;) Could you fix that?
There is another bug. Unfortunately, I didn't see it during the first review :(
In OnStartedLeading handler before you call updateVirtualServersStatusFromEvents or updateVirtualServerRoutessStatusFromEvents, you need to check if lbc.areCustomResourcesEnabled is set. Otherwise, the code like this lbc.virtualServerRouteLister.List() will result into panic: runtime error: invalid memory address or nil pointer dereference
Rulox
commented
Jun 23, 2020
vepatel
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When updating VS and VSR statuses of created resources during a leading election process, those resources won't have their status updated until they're synced again and the KIC instance has become the leader.
With this change, KIC will trigger an update of all VS/VSR statuses based on their last event when the KIC becomes the leader.