Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE #7167

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

DO NOT MERGE #7167

wants to merge 7 commits into from

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Jan 20, 2025

Proposed changes

  • DO NOT MERGE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

saedx1 and others added 7 commits January 3, 2025 11:26
The ideal solution would be to use uint16, however, that will require a bigger amount of change to adjust all types. Int32 should so.

Signed-off-by: Saed SayedAhmed <34514167+saedx1@users.noreply.github.com>
Signed-off-by: Saed SayedAhmed <34514167+saedx1@users.noreply.github.com>
Signed-off-by: Saed SayedAhmed <34514167+saedx1@users.noreply.github.com>
@github-actions github-actions bot added the go Pull requests that update Go code label Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.73%. Comparing base (c449170) to head (458c8f8).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7167   +/-   ##
=======================================
  Coverage   52.73%   52.73%           
=======================================
  Files          89       89           
  Lines       20843    20843           
=======================================
  Hits        10992    10992           
  Misses       9394     9394           
  Partials      457      457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
Status: Todo ☑
Development

Successfully merging this pull request may close these issues.

2 participants