Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make staticcheck, (use NewInformerWithOptions and TypedRateLimitingInterface) #6647

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

j1m-ryan
Copy link

Proposed changes

make staticcheck now passes

kubernetes-ingress:fix/static-check-new-informer-with-options[I] make staticcheck
staticcheck ./...

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added bug An issue reporting a potential bug go Pull requests that update Go code labels Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 53.30%. Comparing base (d3f1246) to head (7527f5a).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/externaldns/controller.go 0.00% 14 Missing ⚠️
internal/externaldns/handlers.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6647   +/-   ##
=======================================
  Coverage   53.29%   53.30%           
=======================================
  Files          87       87           
  Lines       16277    16278    +1     
=======================================
+ Hits         8675     8677    +2     
+ Misses       7187     7186    -1     
  Partials      415      415           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j1m-ryan j1m-ryan changed the title use NewInformerWithOptions and TypedRateLimitingInterface Fix make staticcheck, (use NewInformerWithOptions and TypedRateLimitingInterface) Oct 14, 2024
@j1m-ryan j1m-ryan changed the title Fix make staticcheck, (use NewInformerWithOptions and TypedRateLimitingInterface) Fix make staticcheck, (use NewInformerWithOptions and TypedRateLimitingInterface) Oct 14, 2024
@j1m-ryan j1m-ryan marked this pull request as ready for review October 14, 2024 10:03
@j1m-ryan j1m-ryan requested a review from a team as a code owner October 14, 2024 10:03
@j1m-ryan j1m-ryan added chore Pull requests for routine tasks and removed bug An issue reporting a potential bug labels Oct 14, 2024
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions github-actions bot added bug An issue reporting a potential bug and removed chore Pull requests for routine tasks labels Oct 14, 2024
@j1m-ryan j1m-ryan enabled auto-merge (squash) October 14, 2024 10:54
@j1m-ryan j1m-ryan added chore Pull requests for routine tasks and removed bug An issue reporting a potential bug labels Oct 14, 2024
@j1m-ryan j1m-ryan merged commit 2b979c0 into main Oct 14, 2024
52 of 53 checks passed
@j1m-ryan j1m-ryan deleted the fix/static-check-new-informer-with-options branch October 14, 2024 11:02
@pdabelf5 pdabelf5 removed the go Pull requests that update Go code label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

4 participants