Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpstreamServer Fields Logs Displayed as Memory Addresses #6635

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented Oct 10, 2024

Proposed changes

  • Fixes memory address showing up in log line
  • Add struct field names to log line for clarity.

log line before the fix:

I20241009 15:30:00.204220   1 manager.go:412] Updated servers of vs_default_cafe_coffee; Added: [{0xc000d91928 0xc000d91920 <nil> <nil> <nil> 10.244.0.5:8080 10s    0 false}], Removed: [], Updated: []

log line after the fix:

I20241010 10:28:57.889534   1 manager.go:416] Updated servers of vs_default_cafe_coffee; Added: [{MaxConns:0 MaxFails:1 Backup:false Down:false Weight:0 Server:10.244.0.5:8080 FailTimeout:10s SlowStart: Route: Service: ID:0 Drain:false}], Removed: [], Updated: []

Resolves: #6634

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner October 10, 2024 14:35
@github-actions github-actions bot added bug An issue reporting a potential bug go Pull requests that update Go code labels Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 53.30%. Comparing base (e7e1757) to head (4288f93).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/nginx/manager.go 78.94% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6635      +/-   ##
==========================================
+ Coverage   53.26%   53.30%   +0.03%     
==========================================
  Files          87       87              
  Lines       16257    16277      +20     
==========================================
+ Hits         8660     8677      +17     
- Misses       7182     7185       +3     
  Partials      415      415              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexFenlon AlexFenlon merged commit b4183ea into main Oct 10, 2024
81 checks passed
@AlexFenlon AlexFenlon deleted the fix/manager-log-bug-fix branch October 10, 2024 15:21
@pdabelf5 pdabelf5 changed the title Bug fix for UpstreamServer Fields Logs Displayed as Memory Addresses UpstreamServer Fields Logs Displayed as Memory Addresses Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: UpstreamServer Fields Logs Displayed as Memory Addresses Instead of Actual Values in manager.go
3 participants