Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot testing for templates #5735

Merged
merged 12 commits into from
Jun 19, 2024
Merged

Snapshot testing for templates #5735

merged 12 commits into from
Jun 19, 2024

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented Jun 12, 2024

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jun 12, 2024
@oseoin oseoin changed the title Get feedback on snapshot testing Snapshot testing for templates Jun 16, 2024
@oseoin oseoin marked this pull request as ready for review June 17, 2024 09:20
@oseoin oseoin requested a review from a team as a code owner June 17, 2024 09:20
@oseoin oseoin merged commit e1f0584 into main Jun 19, 2024
78 checks passed
@oseoin oseoin deleted the snapshot-template-tests branch June 19, 2024 12:48
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants