-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-align configurations in helm docs #4790
Conversation
docs/content/installation/installing-nic/installation-with-helm.md
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4790 +/- ##
==========================================
+ Coverage 52.01% 52.04% +0.03%
==========================================
Files 60 60
Lines 17313 17313
==========================================
+ Hits 9005 9011 +6
+ Misses 7995 7991 -4
+ Partials 313 311 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on docs side, I've left an inline suggestion to match @vepatel 's feedback.
Proposed changes
Adds the below list of helm arguments to the Installation with Helm docs:
Removes the below helm argument from the installation with Helm docs:
Checklist
Before creating a PR, run through this checklist and mark each as complete.