Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve runtime batch reloads #4371

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Improve runtime batch reloads #4371

merged 2 commits into from
Sep 20, 2023

Conversation

ciarams87
Copy link
Contributor

Proposed changes

Improve runtime batch updates by only updating all configs when the ConfigMap was one of the updated resources in the batch event. Additionally, ensure endpoint updates for services not referenced in any of the watched resources do not trigger an update.

Testing:

  • Tested locally using services both referenced and not referenced by watched resources.
  • Ran the batch reload test suite and confirmed they pass

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • [] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested a review from a team as a code owner September 18, 2023 14:44
@github-actions github-actions bot added the bug An issue reporting a potential bug label Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #4371 (a218177) into main (3b91d97) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #4371      +/-   ##
==========================================
- Coverage   52.19%   52.08%   -0.11%     
==========================================
  Files          59       59              
  Lines       16929    16956      +27     
==========================================
- Hits         8836     8832       -4     
- Misses       7796     7825      +29     
- Partials      297      299       +2     
Files Changed Coverage Δ
internal/configs/configurator.go 37.68% <0.00%> (-0.27%) ⬇️
internal/k8s/controller.go 11.93% <0.00%> (-0.08%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ciarams87 ciarams87 force-pushed the fix/minimise-configs-update branch 2 times, most recently from 39b3739 to 5896988 Compare September 20, 2023 09:08
@ciarams87 ciarams87 force-pushed the fix/minimise-configs-update branch from 5896988 to a218177 Compare September 20, 2023 12:56
@ciarams87 ciarams87 merged commit 724fd83 into main Sep 20, 2023
@ciarams87 ciarams87 deleted the fix/minimise-configs-update branch September 20, 2023 14:06
@danielnginx danielnginx added this to the v3.3.0 milestone Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants