Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated tests for custom vs listeners #4311

Merged
merged 14 commits into from
Sep 5, 2023

Conversation

haywoodsh
Copy link
Contributor

@haywoodsh haywoodsh commented Aug 31, 2023

Proposed changes

Add automated test for custom listeners for virtual servers #4271
closes #4196

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the tests Pull requests that update tests label Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #4311 (8a990e8) into main (f14e910) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4311      +/-   ##
==========================================
- Coverage   52.19%   52.17%   -0.03%     
==========================================
  Files          59       59              
  Lines       16930    16930              
==========================================
- Hits         8837     8833       -4     
- Misses       7796     7798       +2     
- Partials      297      299       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@haywoodsh haywoodsh force-pushed the tests/add-automated-tests-for-custom-vs-listeners branch 2 times, most recently from 2b7b26f to b932610 Compare September 4, 2023 09:13
@haywoodsh haywoodsh marked this pull request as ready for review September 4, 2023 11:40
@haywoodsh haywoodsh requested a review from a team as a code owner September 4, 2023 11:40
@haywoodsh haywoodsh force-pushed the tests/add-automated-tests-for-custom-vs-listeners branch 2 times, most recently from 9328b98 to 547fa45 Compare September 4, 2023 13:52
@vepatel vepatel requested a review from shaun-nx September 4, 2023 15:22
Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vepatel vepatel self-requested a review September 5, 2023 13:36
Copy link
Contributor

@vepatel vepatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a change request

@vepatel vepatel self-requested a review September 5, 2023 15:02
haywoodsh and others added 13 commits September 5, 2023 16:04
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Co-authored-by: Shaun <s.odonovan@f5.com>
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Co-authored-by: Venktesh Shivam Patel <ve.patel@f5.com>
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
@haywoodsh haywoodsh force-pushed the tests/add-automated-tests-for-custom-vs-listeners branch from fe1fd6a to 8a990e8 Compare September 5, 2023 15:12
@haywoodsh haywoodsh merged commit 94cd817 into main Sep 5, 2023
@haywoodsh haywoodsh deleted the tests/add-automated-tests-for-custom-vs-listeners branch September 5, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new python tests for custom listener controls
3 participants