-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automated tests for custom vs listeners #4311
Add automated tests for custom vs listeners #4311
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4311 +/- ##
==========================================
- Coverage 52.19% 52.17% -0.03%
==========================================
Files 59 59
Lines 16930 16930
==========================================
- Hits 8837 8833 -4
- Misses 7796 7798 +2
- Partials 297 299 +2 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
2b7b26f
to
b932610
Compare
9328b98
to
547fa45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a change request
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com> Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com> Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Co-authored-by: Shaun <s.odonovan@f5.com> Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com> Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com> Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
fe1fd6a
to
8a990e8
Compare
Proposed changes
Add automated test for custom listeners for virtual servers #4271
closes #4196
Checklist
Before creating a PR, run through this checklist and mark each as complete.