-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/upgrade using helm #4272
Docs/upgrade using helm #4272
Conversation
for more information, see https://pre-commit.ci
This commit adds a handful of changes to the Helm upgrade installation guide for NGINX Ingress Controller. It primarily changes the body of text to favour plain English over technical jargon where possible, and also recontextualises it to be less negatively-framed. It also adds some standardised formatting for NGINX products such as the use of note callouts and tabs, and reduces the inline comments to using single backticks instead of triples, which are only necessary for large blocks. The list numeration is also changed to the automatic style.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com> Signed-off-by: Venktesh Shivam Patel <ve.patel@f5.com>
Codecov Report
@@ Coverage Diff @@
## main #4272 +/- ##
==========================================
- Coverage 51.97% 51.95% -0.03%
==========================================
Files 59 59
Lines 16762 16762
==========================================
- Hits 8712 8708 -4
- Misses 7753 7755 +2
- Partials 297 299 +2 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 possible 2 typos? @vepatel could you please check it?
Proposed changes
Preview: https://deploy-preview-4272--nginx-kubernetes-ingress.netlify.app/nginx-ingress-controller/installation/installation-with-helm/#upgrading-without-downtime
Checklist
Before creating a PR, run through this checklist and mark each as complete.