-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add howto doc for path-regex annotations #4266
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4266 +/- ##
==========================================
- Coverage 51.97% 51.95% -0.03%
==========================================
Files 59 59
Lines 16762 16762
==========================================
- Hits 8712 8708 -4
- Misses 7753 7755 +2
- Partials 297 299 +2 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but I made a lot of suggestions about nouns, prepositions and articles.
There's also a lot of missing punctuation for the end of instruction steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
This PR adds a document guiding users how to apply
nginx.org/path-regex
annotations to simple and mergeable ingresses.Checklist
Before creating a PR, run through this checklist and mark each as complete.