Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go docs for path-regex #4248

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Update Go docs for path-regex #4248

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4231f4
Update Go docs for path-regex
jjngx Aug 16, 2023
5f72b58
Merge branch 'main' into feat/path-regex
jjngx Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions internal/configs/version1/template_helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,8 @@ func trim(s string) string {
// if no path-regex annotation is present in ingressAnnotations
// or in Location's Ingress.
//
// Annotation 'path-regex' set on a Minion Ingress will take priority over
// the annotation set on the master (in Master-Minion Ingress setup).
// If no annotation 'path-regex' is set on Minion and only on Ingress (including master),
// all location paths will be updated using provided regex modifier types.
// Annotations 'path-regex' are set only on Minions. If set on Master Ingress,
// they are ignored and have no effect.
func makeLocationPath(loc *Location, ingressAnnotations map[string]string) string {
if loc.MinionIngress != nil {
// Case when annotation 'path-regex' set on Location's Minion.
Expand Down