-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit note to that docs apply to latest release #4093
Conversation
These commits add a small note near the prerequisites part of a few installation-based sections of the documentation to draw the reader's attention towards the fact that documentation applies only to the latest release for NGINX Ingress Controller.
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
Codecov Report
@@ Coverage Diff @@
## main #4093 +/- ##
==========================================
- Coverage 51.88% 51.84% -0.04%
==========================================
Files 59 59
Lines 16710 16710
==========================================
- Hits 8670 8664 -6
- Misses 7743 7747 +4
- Partials 297 299 +2 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@ADubhlaoich I ask because it reads like a disclaimer, rather than noting that the URL is release version sensitive. <- which I think is a more instructive way to address the problem. I assume that we have some feedback that main is being used to reference documents while using some older release. You can DM me any details of the reasoning. |
we also don't have a way to point people to a different version of the docs if they're not using the latest release, so this might be confusing. |
Proposed changes
These commits add a small note near the prerequisites part of a few installation-based sections of the documentation to draw the reader's attention towards the fact that documentation applies only to the latest release for NGINX Ingress Controller.
Checklist
Before creating a PR, run through this checklist and mark each as complete.