Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alpine image with FIPS inside #4031

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Add Alpine image with FIPS inside #4031

merged 1 commit into from
Jun 21, 2023

Conversation

lucacome
Copy link
Member

Proposed changes

Adds a new image with FIPS module and necessary configuration. The nginx-plus-module-fips-check was added to the base images. This lightweight module adds a line to the nginx output log printing whether FIPS mode is enabled or not.

@lucacome lucacome added this to the v3.2.0 milestone Jun 20, 2023
@lucacome lucacome requested a review from a team as a code owner June 20, 2023 17:19
@lucacome lucacome self-assigned this Jun 20, 2023
@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Jun 20, 2023
@github-actions
Copy link

github-actions bot commented Jun 20, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #4031 (df760a9) into main (0f8992d) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head df760a9 differs from pull request most recent head 8bf59f6. Consider uploading reports for the commit 8bf59f6 to get more accurate results

@@            Coverage Diff             @@
##             main    #4031      +/-   ##
==========================================
- Coverage   51.85%   51.83%   -0.03%     
==========================================
  Files          59       59              
  Lines       16705    16705              
==========================================
- Hits         8663     8659       -4     
- Misses       7745     7747       +2     
- Partials      297      299       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome force-pushed the feat/add-fips-image branch from df760a9 to c7c5be8 Compare June 20, 2023 21:38
@vepatel
Copy link
Contributor

vepatel commented Jun 21, 2023

I think we should add a test-run job for alpine-plus-fips image as well, maybe something like {\"image\": \"alpine-plus-fips\", \"marker\":\"policies\"}, \ in our setup-matrix.

Update: tests on this image should only run in a FIPS compliant clusters

Adds a new image with FIPS module and necessary configuration.
The nginx-plus-module-fips-check was added to the base images. This
lightweight module adds a line to the nginx output log printing whether
FIPS mode is enabled or not.
@lucacome lucacome force-pushed the feat/add-fips-image branch from c7c5be8 to 8bf59f6 Compare June 21, 2023 16:55
@lucacome lucacome merged commit 5092001 into main Jun 21, 2023
@lucacome lucacome deleted the feat/add-fips-image branch June 21, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants