Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update numbering in manifest installation #4015

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Jun 16, 2023

Proposed changes

  • update numbering in manifest installation document

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner June 16, 2023 10:49
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jun 16, 2023
@github-actions
Copy link

github-actions bot commented Jun 16, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #4015 (2e9699c) into main (accba9d) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 2e9699c differs from pull request most recent head 13c0d40. Consider uploading reports for the commit 13c0d40 to get more accurate results

@@            Coverage Diff             @@
##             main    #4015      +/-   ##
==========================================
- Coverage   51.84%   51.83%   -0.02%     
==========================================
  Files          59       59              
  Lines       16697    16697              
==========================================
- Hits         8657     8655       -2     
- Misses       7743     7745       +2     
  Partials      297      297              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vepatel vepatel merged commit 439ad79 into main Jun 19, 2023
@vepatel vepatel deleted the docs/updates-installation-bullets branch June 19, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants