Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NGINX Dynamic module with NGINX Ingress controller #3992

Merged
merged 14 commits into from
Sep 6, 2023

Conversation

jasonwilliams14
Copy link
Contributor

@jasonwilliams14 jasonwilliams14 commented Jun 12, 2023

Proposed changes

Doc describing how to build NGINX Ingress with a NGINX plus dynamic module.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jun 12, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #3992 (5269e9c) into main (94cd817) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3992      +/-   ##
==========================================
- Coverage   52.20%   52.17%   -0.04%     
==========================================
  Files          59       59              
  Lines       16930    16930              
==========================================
- Hits         8839     8833       -6     
- Misses       7794     7798       +4     
- Partials      297      299       +2     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jasonwilliams14 jasonwilliams14 marked this pull request as ready for review June 21, 2023 15:09
@jasonwilliams14 jasonwilliams14 requested a review from a team as a code owner June 21, 2023 15:09
@brianehlert brianehlert added this to the v3.3.0 milestone Jun 21, 2023
docs/content/tutorials/nginx-dynamic-module.md Outdated Show resolved Hide resolved
docs/content/tutorials/nginx-dynamic-module.md Outdated Show resolved Hide resolved
docs/content/tutorials/nginx-dynamic-module.md Outdated Show resolved Hide resolved
docs/content/tutorials/nginx-dynamic-module.md Outdated Show resolved Hide resolved
docs/content/tutorials/nginx-dynamic-module.md Outdated Show resolved Hide resolved
docs/content/tutorials/nginx-dynamic-module.md Outdated Show resolved Hide resolved
docs/content/tutorials/nginx-dynamic-module.md Outdated Show resolved Hide resolved
docs/content/tutorials/nginx-dynamic-module.md Outdated Show resolved Hide resolved
docs/content/tutorials/nginx-dynamic-module.md Outdated Show resolved Hide resolved
docs/content/tutorials/nginx-dynamic-module.md Outdated Show resolved Hide resolved
@lucacome lucacome requested a review from a team June 21, 2023 17:56
Co-authored-by: Luca Comellini <luca.com@gmail.com>
Signed-off-by: Jason Williams - NGIИX <jason.williams14@gmail.com>
@github-actions
Copy link

github-actions bot commented Jun 22, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

jasonwilliams14 and others added 3 commits June 22, 2023 11:19
Co-authored-by: Luca Comellini <luca.com@gmail.com>
Signed-off-by: Jason Williams - NGIИX <jason.williams14@gmail.com>
Signed-off-by: Jason Williams - NGIИX <jason.williams14@gmail.com>
Co-authored-by: Luca Comellini <luca.com@gmail.com>
Signed-off-by: Alan Dooley <ADubhlaoich@users.noreply.github.com>
Signed-off-by: Alan Dooley <ADubhlaoich@users.noreply.github.com>
@ADubhlaoich ADubhlaoich marked this pull request as draft July 10, 2023 10:35
This commit makes a few small structural changes to the page and
rephrases multiple sentences for clarify and conciseness. Notably, it
might be the first example of the tab component used in other NGINX
documentation for NGINX Ingress Controller.
@ADubhlaoich ADubhlaoich marked this pull request as ready for review July 10, 2023 11:55
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a lot of changes directly into this PR; they will need to be reviewed for accuracy, as I re-ordered certain examples for clarify while doing my best to keep the intent.

Signed-off-by: Jason Williams - NGIИX <jason.williams14@gmail.com>
@vepatel vepatel requested a review from shaun-nx August 23, 2023 15:09
@shaun-nx shaun-nx merged commit 312be1d into main Sep 6, 2023
@shaun-nx shaun-nx deleted the docs/nginx-dynamic-module branch September 6, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants