Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify validation code for listener protocol #3885

Merged
merged 2 commits into from
May 9, 2023
Merged

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented May 8, 2023

Proposed changes

This PR simplifies validation code for listener protocol.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • [] I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner May 8, 2023 21:38
@github-actions github-actions bot added the chore Pull requests for routine tasks label May 8, 2023
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #3885 (b08a146) into main (adba092) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3885      +/-   ##
==========================================
- Coverage   51.95%   51.91%   -0.04%     
==========================================
  Files          59       59              
  Lines       16759    16755       -4     
==========================================
- Hits         8707     8699       -8     
- Misses       7756     7758       +2     
- Partials      296      298       +2     
Impacted Files Coverage Δ
...g/apis/configuration/validation/transportserver.go 96.31% <100.00%> (-0.06%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jjngx jjngx merged commit 18a37de into main May 9, 2023
@jjngx jjngx deleted the chore/validators branch May 9, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants