Add Funcs() method to UpdateVirtualServerTemplate method #3870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3870 +/- ##
=======================================
Coverage 51.95% 51.95%
=======================================
Files 59 59
Lines 16759 16759
=======================================
Hits 8707 8707
Misses 7756 7756
Partials 296 296
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lucacome
approved these changes
May 6, 2023
ciarams87
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently using a custom template for virtualservers will result in this error. This is because the helper function used does not exist when updating the virtualserver template only when using the default virtualserver template.
I0505 15:29:26.116535 1 event.go:285] Event(v1.ObjectReference{Kind:"VirtualServer", Namespace:"egress-proxy-qa", Name:"pubsub", UID:"cea53bfa-7c8f-4923-9658-4d35b370bf9e", APIVersion:"k8s.nginx.org/v1", ResourceVersion:"388565630", FieldPath:""}): type: 'Warning' reason: 'AddedOrUpdatedWithError' Configuration for egress-proxy-qa/pubsub was added or updated ; but was not applied: error when parsing the VirtualServer template: template: virtualServerTemplate:550: function "headerListToCIMap" not definedChecklist
Before creating a PR, run through this checklist and mark each as complete.