Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gunzip for VS #3790

Merged
merged 16 commits into from
Apr 25, 2023
Merged

Gunzip for VS #3790

merged 16 commits into from
Apr 25, 2023

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Apr 18, 2023

Proposed changes

This PR introduces gunzip functionality setup on the server (VS).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements helm_chart Pull requests that update the Helm Chart labels Apr 18, 2023
@jjngx jjngx marked this pull request as ready for review April 20, 2023 08:54
@jjngx jjngx requested a review from a team as a code owner April 20, 2023 08:54
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #3790 (1485ea9) into main (dd84a78) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3790      +/-   ##
==========================================
+ Coverage   52.38%   52.40%   +0.01%     
==========================================
  Files          59       59              
  Lines       16891    16898       +7     
==========================================
+ Hits         8848     8855       +7     
  Misses       7748     7748              
  Partials      295      295              
Impacted Files Coverage Δ
internal/configs/version2/http.go 0.00% <ø> (ø)
pkg/apis/configuration/validation/virtualserver.go 94.42% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Apr 24, 2023
@haywoodsh
Copy link
Contributor

Looks good @jjngx! Left a comment about documentation.
Also, I noticed this on the nginx docs:

This module is not built by default, it should be enabled with the --with-http_gunzip_module configuration parameter.

Have you encountered any issues when running OSS and Plus version?

@jjngx jjngx merged commit af076fe into main Apr 25, 2023
@jjngx jjngx deleted the feat/gunzip-vs branch April 25, 2023 10:26
@shaun-nx shaun-nx added this to the v3.2.0 milestone Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements helm_chart Pull requests that update the Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants