-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs theme updates #3751
Docs theme updates #3751
Conversation
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #3751 +/- ##
==========================================
- Coverage 52.35% 52.33% -0.03%
==========================================
Files 59 59
Lines 16880 16880
==========================================
- Hits 8838 8834 -4
- Misses 7747 7749 +2
- Partials 295 297 +2 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤩 🚀
…ngress into docs-theme-updates
Proposed changes
This PR changes the configurations for the docs theme. We have moved the theme development to GitHub so it will be accessible in Netlify builds (and the _vendors directory is no longer required). The changes in this PR also let us manage future theme bumps by updating the NGINX_THEME_VERSION variable stored in the Netlify console.
The dev and staging sites are already updated with the changes. Following the merge of this PR, we will need to port the update to the release branch, too.
Checklist
Before creating a PR, run through this checklist and mark each as complete.