Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs theme updates #3751

Merged
merged 5 commits into from
Apr 14, 2023
Merged

Docs theme updates #3751

merged 5 commits into from
Apr 14, 2023

Conversation

jputrino
Copy link
Contributor

@jputrino jputrino commented Apr 11, 2023

Proposed changes

This PR changes the configurations for the docs theme. We have moved the theme development to GitHub so it will be accessible in Netlify builds (and the _vendors directory is no longer required). The changes in this PR also let us manage future theme bumps by updating the NGINX_THEME_VERSION variable stored in the Netlify console.

The dev and staging sites are already updated with the changes. Following the merge of this PR, we will need to port the update to the release branch, too.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jputrino jputrino requested a review from a team as a code owner April 11, 2023 21:55
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Apr 11, 2023
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #3751 (cd7ebf1) into main (082a7c0) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3751      +/-   ##
==========================================
- Coverage   52.35%   52.33%   -0.03%     
==========================================
  Files          59       59              
  Lines       16880    16880              
==========================================
- Hits         8838     8834       -4     
- Misses       7747     7749       +2     
- Partials      295      297       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! 🚀

Copy link
Contributor

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 🚀

docs/Makefile Outdated Show resolved Hide resolved
@jputrino jputrino requested a review from tomasohaodha April 12, 2023 20:05
@tomasohaodha tomasohaodha merged commit 35c985d into main Apr 14, 2023
@tomasohaodha tomasohaodha deleted the docs-theme-updates branch April 14, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants