Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prometheus exporter image for Plus #301

Merged
merged 1 commit into from
Jun 28, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions docs/installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ For NGINX Plus, you can access the live activity monitoring dashboard:

## Support For Prometheus Monitoring

If you are using [Prometheus](https://prometheus.io/), you can deploy the NGINX Plus Ingress controller with the prometheus exporter for NGINX Plus. The exporter will export NGINX Plus metrics into your Prometheus. To deploy the Ingress controller with the exporter, use the modified manifests:
If you are using [Prometheus](https://prometheus.io/), you can deploy the NGINX Plus Ingress controller with the Prometheus exporter for NGINX Plus. The exporter will export NGINX Plus metrics into your Prometheus. To deploy the Ingress controller with the exporter, use the modified manifests:
* For a deployment, run:
```
$ kubectl apply -f deployment/nginx-plus-ingress-with-prometheus.yaml
Expand All @@ -161,8 +161,6 @@ If you are using [Prometheus](https://prometheus.io/), you can deploy the NGINX
$ kubectl apply -f daemon-set/nginx-plus-ingress-with-prometheus.yaml
```

**Note**: this is a preview version of the prometheus exporter for NGINX Plus. It is not suitable for using in production environments.

## Uninstall the Ingress Controller

Delete the `nginx-ingress` namespace to uninstall the Ingress controller along with all the auxiliary resources that were created:
Expand Down
2 changes: 1 addition & 1 deletion docs/nginx-ingress-controllers.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ The table below summarizes the key difference between nginxinc/kubernetes-ingres
| **Operational** |
| Reporting the IP address(es) of the Ingress controller into Ingress resources | Supported | Coming soon | Coming soon |
| Extended Status | Supported via a third-party module | Not supported | Supported |
| Prometheus Integration | Supported | Not supported | Supported (in beta) |
| Prometheus Integration | Supported | Not supported | Supported |
| Dynamic reconfiguration of endpoints (no configuration reloading) | Supported with a third-party Lua module | Not supported | Supported |

Notes:
Expand Down
17 changes: 10 additions & 7 deletions install/daemon-set/nginx-plus-ingress-with-prometheus.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ spec:
app: nginx-ingress
annotations:
prometheus.io/scrape: "true"
prometheus.io/port: "8090"
prometheus.io/port: "9113"
spec:
serviceAccountName: nginx-ingress
containers:
Expand All @@ -36,11 +36,14 @@ spec:
- -nginx-configmaps=$(POD_NAMESPACE)/nginx-config
- -default-server-tls-secret=$(POD_NAMESPACE)/default-server-secret
#- -v=3 # Enables extensive logging. Useful for trooublshooting.
- image: nginxdemos/nginxplus-prometheus-exporter:0.1.0
name: nginxplus-prometheus-exporter
- image: nginx/nginx-prometheus-exporter:0.1.0
name: nginx-prometheus-exporter
ports:
- name: prometheus
containerPort: 9113
args:
- -listen-address
- :8090
- -plus
- -metric-endpoint
- -web.listen-address
- :9113
- -nginx.plus
- -nginx.scrape-uri
- http://127.0.0.1:8080/api
17 changes: 10 additions & 7 deletions install/deployment/nginx-plus-ingress-with-prometheus.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
app: nginx-ingress
annotations:
prometheus.io/scrape: "true"
prometheus.io/port: "8090"
prometheus.io/port: "9113"
spec:
serviceAccountName: nginx-ingress
containers:
Expand All @@ -35,11 +35,14 @@ spec:
- -nginx-configmaps=$(POD_NAMESPACE)/nginx-config
- -default-server-tls-secret=$(POD_NAMESPACE)/default-server-secret
#- -v=3 # Enables extensive logging. Useful for trooublshooting.
- image: nginxdemos/nginxplus-prometheus-exporter:0.1.0
name: nginxplus-prometheus-exporter
- image: nginx/nginx-prometheus-exporter:0.1.0
name: nginx-prometheus-exporter
ports:
- name: prometheus
containerPort: 9113
args:
- -listen-address
- :8090
- -plus
- -metric-endpoint
- -web.listen-address
- :9113
- -nginx.plus
- -nginx.scrape-uri
- http://127.0.0.1:8080/api