Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RBAC in Helm template #2593

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Update RBAC in Helm template #2593

merged 3 commits into from
Apr 12, 2022

Conversation

ciarams87
Copy link
Contributor

Proposed changes
Updating the Helm RBAC template with cert-manager permissions was missed in the original PR.

Also update example to use latest cert-manager deployment yaml.

@ciarams87 ciarams87 requested review from a team, lucacome, haywoodsh and shaun-nx April 11, 2022 13:52
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Apr 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2022

Codecov Report

Merging #2593 (b448611) into main (192c76f) will decrease coverage by 0.08%.
The diff coverage is 38.88%.

@@            Coverage Diff             @@
##             main    #2593      +/-   ##
==========================================
- Coverage   53.53%   53.44%   -0.09%     
==========================================
  Files          52       52              
  Lines       14691    14696       +5     
==========================================
- Hits         7865     7855      -10     
- Misses       6568     6579      +11     
- Partials      258      262       +4     
Impacted Files Coverage Δ
cmd/nginx-ingress/main.go 6.86% <0.00%> (-0.06%) ⬇️
internal/configs/config_params.go 76.74% <ø> (ø)
internal/configs/version1/config.go 0.00% <ø> (ø)
internal/k8s/controller.go 10.87% <20.00%> (ø)
internal/configs/configmaps.go 18.22% <100.00%> (ø)
pkg/apis/configuration/validation/policy.go 94.42% <100.00%> (-2.13%) ⬇️
internal/k8s/configuration.go 95.47% <0.00%> (-0.39%) ⬇️
...ternal/k8s/appprotect/app_protect_configuration.go 86.74% <0.00%> (+0.57%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lucacome lucacome merged commit ed598e5 into main Apr 12, 2022
@lucacome lucacome deleted the certmanager-fixes branch April 12, 2022 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants