AP: Deprecate external refs

[rafwegv]

Proposed changes

Add a warning when an external refs field is detected in the policy.
This is the first stage of deprecation. In next release the policy will become invalid , and further down the line the fields will be removed from the crd.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have checked that all unit tests pass after adding my changes
• I have updated necessary documentation
• I have rebased my branch onto master
• I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

[rafwegv]

Hi @soneillf5 @pleshakov I would appreciate input on where would be a good place to document this change, to make any customers aware of the deprecation.

[brianehlert]

@rafwegv
Bare minimum is release notes.
I would add a deprecation note into the docs where the configuration option is presented to make it very clear.

[codecov-commenter]

Codecov Report

Merging #2249 (bb50645) into master (56a7bfb) will decrease coverage by 0.00%.
The diff coverage is 77.77%.

❗ Current head bb50645 differs from pull request most recent head ba60891. Consider uploading reports for the commit ba60891 to get more accurate results

@@            Coverage Diff             @@
##           master    #2249      +/-   ##
==========================================
- Coverage   53.66%   53.65%   -0.01%     
==========================================
  Files          48       48              
  Lines       14200    14218      +18     
==========================================
+ Hits         7620     7629       +9     
- Misses       6342     6348       +6     
- Partials      238      241       +3     

Impacted Files	Coverage Δ
pkg/apis/configuration/validation/appprotect.go	76.19% <58.33%> (-23.81%)	⬇️
internal/configs/configurator.go	37.54% <100.00%> (+0.03%)	⬆️
internal/configs/ingress.go	76.59% <100.00%> (-0.05%)	⬇️
internal/configs/virtualserver.go	95.32% <100.00%> (ø)
internal/k8s/configuration.go	95.86% <100.00%> (ø)
...apis/configuration/validation/appprotect_common.go	98.00% <100.00%> (ø)
pkg/apis/configuration/validation/virtualserver.go	96.24% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a7bfb...ba60891. Read the comment docs.

[AmitShnek]

@rafwegv ?

[rafwegv]

Hi @brianehlert i have added a note in the config docs. As I understand that will be then referenced in the release notes.

[soneillf5]

@rafwegv Are there any tests associated with this change? How do we know this works and doesn't break in the future?

[rafwegv]

@soneillf5 This feature does not touch the kic code, it goes straight to the file on storage without any checks. This PR is only meant to warn the admin that this feature is going to go away in the future.

[lucacome]

Is this PR still relevant? I couldn't find any reference to the deprecation of external reference in NAP WAF docs. If so I left a comment.

[lucacome]

@rafwegv I noticed that the are a lot of changes to unrelated files, but it looks like it's about formatting and spaces so I approved it anyway