Apply -enable-snippets cli arg to Ingresses #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
added
enhancement
github-actions
bot
added
the
documentation
soneillf5
reviewed
Oct 26, 2021
soneillf5
force-pushed
the
feature/ingress-snippets
branch
2 times, most recently
from
de405e4 to
a288b9f
Compare
soneillf5
approved these changes
Oct 26, 2021
nginx-bot
force-pushed
the
feature/ingress-snippets
branch
from
17e7349 to
c2ad243
Compare
| indirect=["ingress_controller"]) | ||
| def test_snippet_annotation_ignored(self, kube_apis, ingress_controller_prerequisites, ingress_controller, test_namespace): | ||
| file_name = f"{TEST_DATA}/annotations/standard/annotations-ingress-snippets.yaml" | ||
| create_ingress_from_yaml(kube_apis.networking_v1, test_namespace, file_name) |
There was a problem hiding this comment.
Why do we not need to save the name of this ingress and then delete it after the test as we did in the previous test?
There was a problem hiding this comment.
I found that the ingress is not created as it is rejected as invalid ?
There was a problem hiding this comment.
Makes sense - I was mixing up ingress and ingress controller, thanks
nginx-bot
force-pushed
the
feature/ingress-snippets
branch
from
ad5c0fe to
c5e1549
Compare
lucacome
force-pushed
the
feature/ingress-snippets
branch
from
c5e1549 to
0b00866
Compare
github-actions
bot
added
the
dependencies
|
changed the base branch to release-2.0 |
vepatel
approved these changes
Oct 28, 2021
ciarams87
approved these changes
Oct 28, 2021
pleshakov
added a commit
that referenced
this pull request
Oct 28, 2021
* Apply -enable-snippets cli arg to Ingresses * Update docs * add snippet flag python tests * removing snippets check as we rely on validation * removing used param Co-authored-by: Sean O'Neill <s.oneill@f5.com>
ciarams87
pushed a commit
that referenced
this pull request
Oct 28, 2021
* Apply -enable-snippets cli arg to Ingresses * Update docs * add snippet flag python tests * removing snippets check as we rely on validation * removing used param Co-authored-by: Sean O'Neill <s.oneill@f5.com>
lucacome
removed
enhancement
|
FYI pushing breaking changes within a bugfix release is a bad practice. We had an outage in development environments due to this. From https://semver.org/
|
|
Also, can you please update the docs to reflect this CLI flags larger impact in 2.0.3? |
lucacome
added a commit
that referenced
this pull request
Nov 4, 2021
* fix: Updated theme hugo * Apply -enable-snippets cli arg to Ingresses (#2124) * Apply -enable-snippets cli arg to Ingresses * Update docs * add snippet flag python tests * removing snippets check as we rely on validation * removing used param Co-authored-by: Sean O'Neill <s.oneill@f5.com> * Install libcurl on OpenTracing for NGINX Plus (#2132) * DRAFT: Release v2.0.3 Co-authored-by: Ashutosh Pradhan <a.pradhan@f5.com> Co-authored-by: Michael Pleshakov <pleshakov@users.noreply.github.com> Co-authored-by: Sean O'Neill <s.oneill@f5.com> Co-authored-by: Ciara Stacke <c.stacke@f5.com>
lucacome
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR extends the existing
-enable-snippetscli argument to apply to Ingress resources. If snippets are not enabled, the Ingress Controller will reject any Ingress resources with snippets annotations.Previously, the argument only applied to VirtualServer, VirtualServerRoute and TransportServer resources.
Note: this is a breaking change. Because the default value of
-enable-snippetsisfalse, If you're using snippets in Ingress resources, make sure to explicitly set the-enable-snippetstotruebefore upgrading the Ingress Controller, so that the new version of the Ingress Controller doesn't reject Ingresses with snippets annotations.TO-DO: