AP: update appolicies crd

[galitskiy]

Proposed changes

Update CRD for appolicies. Add new fields: bot-defense>browserDefinition, grpc-profiles>idl-files>importUrl, whitelist-ips>neverLogRequests, enforcer-settings, $action (where applicable)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have checked that all unit tests pass after adding my changes
• I have updated necessary documentation
• I have rebased my branch onto master
• I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

[AvriBalofsky]

Technically even though we added $action: "delete" as a general option, it's not really relevant/functional on the endpoints. Like on collections that the user can't add/remove elements from (bot anomalies, signatures), or collections that start empty (signature-requirements, whitelist-ips, *-validation-files, etc). It's not harmful though.

[pleshakov]

Hi @galitskiy

a few comments:

(1)
Would it be possible to get a better description what this PR addresses? For example: "Improve validation for fields: ; add new fields: ....." This will ultimately go into the changelog -- https://docs.nginx.com/nginx-ingress-controller/releases/ -- so that our users are aware.

(2)
we have examples of policies in our docs -- https://docs.nginx.com/nginx-ingress-controller/app-protect/configuration/#app-protect-policies and in the examples on GitHub (https://github.com/nginxinc/kubernetes-ingress/blob/master/examples-of-custom-resources/waf/ap-dataguard-alarm-policy.yaml and https://github.com/nginxinc/kubernetes-ingress/blob/master/examples/appprotect/ap-dataguard-alarm-policy.yaml ). Just double checking, if we need to update any of the examples as well?

(3)
Could you also update this file? https://github.com/nginxinc/kubernetes-ingress/blob/master/deployments/common/crds/appprotect.f5.com_appolicies.yaml

Thanks

[galitskiy]

Hi @pleshakov
(1) done. @AvriBalofsky could you please take a look as well?
(2) afaik it's not needed; new field "neverLogRequests" was mentioned in RN for latest NAP.
(3) done