Add ubi based AP Dockerfile #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
suggested changes
Jul 10, 2020
There was a problem hiding this comment.
@rafwegv thanks. I left a few suggestions.
Could you also update this doc https://github.com/nginxinc/kubernetes-ingress/blob/master/docs-web/technical-specifications.md to include info about this image?
perhaps it also make sense to mention the OpenShift option here https://deploy-preview-1046--nginx-kubernetes-ingress.netlify.app/nginx-ingress-controller/app-protect/installation/#build-the-docker-image ?
Rulox
approved these changes
Jul 10, 2020
Rulox
requested review from
Dean-Coakley and
pleshakov
and removed request for
pleshakov
Dean-Coakley
approved these changes
Jul 10, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add a Dockerfile to build Ingress Controller with App Protect based on UBI for use with OpenShift.
Checklist
Before creating a PR, run through this checklist and mark each as complete.