Skip to content

chore: Remove unnecessary task when installing modules on Alpine Linux #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2024
Merged

chore: Remove unnecessary task when installing modules on Alpine Linux #757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ TESTS:

- Update RHEL UBI images to UBI 8.10 and UBI 9.4.

MAINTENANCE:

- Installing certain NGINX modules on Alpine Linux 3.17 no longer requires installing `nginx-plus-module-ndk` as a separate step.

CI/CD:

- Update GitHub Actions to Ubuntu 24.04.
Expand Down
35 changes: 18 additions & 17 deletions tasks/modules/install-modules.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,29 @@
---
- name: (AlmaLinux/Amazon Linux/Oracle Linux/RHEL/Rocky Linux) Install GeoIP2 and/or OpenTracing EPEL dependency
- name: (AlmaLinux/Amazon Linux/Oracle Linux/RHEL/Rocky Linux) Install OpenTracing EPEL dependency
when:
- ansible_facts['os_family'] == "RedHat"
- not (ansible_facts['distribution'] == "Amazon" and ansible_facts['distribution_major_version'] is version('2023', '=='))
- ('opentracing' in nginx_modules)
- nginx_install_epel_release | bool
block:
- name: (AlmaLinux/Amazon Linux/Oracle Linux/RHEL/Rocky Linux) Import EPEL GPG key
ansible.builtin.rpm_key:
state: present
key: https://dl.fedoraproject.org/pub/epel/RPM-GPG-KEY-EPEL-{{ ((ansible_facts['distribution'] == 'Amazon') | ternary('7', ansible_facts['distribution_major_version'])) }}
- name: (AlmaLinux/Amazon Linux/Oracle Linux/RHEL/Rocky Linux) Install EPEL dependency
when: ansible_facts['distribution'] != "Amazon"
block:
- name: (AlmaLinux/Oracle Linux/RHEL/Rocky Linux) Import EPEL GPG key
ansible.builtin.rpm_key:
state: present
key: https://dl.fedoraproject.org/pub/epel/RPM-GPG-KEY-EPEL-{{ ansible_facts['distribution_major_version'] }}

- name: (AlmaLinux/Amazon Linux/Oracle Linux/RHEL/Rocky Linux) Install EPEL
ansible.builtin.yum:
name: https://dl.fedoraproject.org/pub/epel/epel-release-latest-{{ ((ansible_facts['distribution'] == 'Amazon') | ternary('7', ansible_facts['distribution_major_version'])) }}.noarch.rpm
- name: (AlmaLinux/Oracle Linux/RHEL/Rocky Linux) Install EPEL
ansible.builtin.yum:
name: https://dl.fedoraproject.org/pub/epel/epel-release-latest-{{ ansible_facts['distribution_major_version'] }}.noarch.rpm

- name: (Alpine Linux) Install Lua and Encrypted Sessions Alpine Linux 3.17 dependency
community.general.apk:
name: nginx-plus-module-ndk
when:
- nginx_type == 'plus'
- ansible_facts['os_family'] == 'Alpine'
- ansible_facts['distribution_version'] | regex_search('^[0-9]+\\.[0-9]+') is version('3.17', '==')
- ('encrypted-sessions' in nginx_modules) or ('lua' in nginx_modules) or ('set-misc' in nginx_modules)
- name: (Amazon Linux) Install EPEL
ansible.builtin.command:
cmd: amazon-linux-extras install -y epel
creates: /etc/yum.repos.d/epel.repo
when:
- ansible_facts['distribution'] == "Amazon"
- ansible_facts['distribution_major_version'] is version('2', '==')

- name: Install NGINX modules
ansible.builtin.package:
Expand Down