-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NGINX Agent config validation #1039
base: v3
Are you sure you want to change the base?
Conversation
# host: "127.0.0.1" # Command server host | ||
# port: 8080 # Command server port | ||
# type: 0 # Server type (e.g., 0 for gRPC) | ||
# host: "agent.connect.nginx.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure why the host and port has been changed from localhost to this host?
@@ -5,7 +5,7 @@ | |||
# | |||
|
|||
log: | |||
# set log level (error, info, debug; default "info") | |||
# set log level (error, warn, info, debug; default "info") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github wont allow me to click on the other file for some reason, but some of the test files have fatal as an option and dont have warn. The default also doesnt have warn as an option looking at it, should that be changed ?
Proposed changes
nginx-agent.conf
file.Example log messages:
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentmake install-tools
and have attached any dependency changes to this pull requestREADME.md
)