Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vula: init at 0.2.2023112801 #97

Merged
merged 8 commits into from
May 2, 2024
Merged

vula: init at 0.2.2023112801 #97

merged 8 commits into from
May 2, 2024

Conversation

lorenzleutgeb
Copy link
Member

No description provided.

@lorenzleutgeb lorenzleutgeb mentioned this pull request Nov 20, 2023
Closed
@lorenzleutgeb lorenzleutgeb changed the title vula: init at 0.1.16 vula: init at 0.2.2023112801 Dec 22, 2023
@ngi-nix ngi-nix deleted a comment from github-actions bot Apr 30, 2024
@ngi-nix ngi-nix deleted a comment from github-actions bot Apr 30, 2024
@ngi-nix ngi-nix deleted a comment from github-actions bot Apr 30, 2024
@ngi-nix ngi-nix deleted a comment from github-actions bot Apr 30, 2024
@wegank wegank marked this pull request as ready for review April 30, 2024 12:25
@wegank wegank merged commit 9048d58 into main May 2, 2024
3 checks passed
@wegank wegank deleted the vula branch May 2, 2024 07:47
};

testScript = {nodes, ...}: ''
start_all()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wegank this is not a test. Did you test Vula in any way manually?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, no. Should I drop test.nix in another PR?

Copy link
Member Author

@lorenzleutgeb lorenzleutgeb May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, that'll be on my head, since I left this PR open. The issue I ran into with this PR is mentioned in #96 (comment)

I'd say we keep test.nix as-is for now, but leave #96 open until we have a fix ("fix forward", as Valentin would say).

Ideally, it would be great if you could diagnose and fix this, but I am not sure about your capacity.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngi-nix/mob-cake xor @ngi-nix/mob-magic could take on the debugging.

Copy link
Member Author

@lorenzleutgeb lorenzleutgeb May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyone: In case you start working on this, please comment in #96 and resolve this conversation. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants