-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vula: init at 0.2.2023112801 #97
Conversation
}; | ||
|
||
testScript = {nodes, ...}: '' | ||
start_all() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wegank this is not a test. Did you test Vula in any way manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, no. Should I drop test.nix in another PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, that'll be on my head, since I left this PR open. The issue I ran into with this PR is mentioned in #96 (comment)
I'd say we keep test.nix
as-is for now, but leave #96 open until we have a fix ("fix forward", as Valentin would say).
Ideally, it would be great if you could diagnose and fix this, but I am not sure about your capacity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ngi-nix/mob-cake xor @ngi-nix/mob-magic could take on the debugging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyone: In case you start working on this, please comment in #96 and resolve this conversation. Thanks.
No description provided.