Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support tidb's new rowformat input #317

Merged
merged 3 commits into from
Jan 3, 2020
Merged

support tidb's new rowformat input #317

merged 3 commits into from
Jan 3, 2020

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Jan 3, 2020

relate to pingcap/tidb#12634

support TiDB write new format data to unionstore and always return new format data

this pr also makes unistore and tidb use same rowcode lib


This change is Reviewable

@cfzjywxk
Copy link
Contributor

cfzjywxk commented Jan 3, 2020

@coocood PTAL

Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -2,11 +2,11 @@ package tikv

import (
"bytes"
"github.com/pingcap/tidb/util/codec"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import order

@coocood
Copy link
Collaborator

coocood commented Jan 3, 2020

LGTM

@coocood coocood merged commit 15763d1 into ngaut:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants