Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to compile on 10.15.3 Catalina #328

Closed
CobaltGray opened this issue Mar 11, 2020 · 2 comments
Closed

Fails to compile on 10.15.3 Catalina #328

CobaltGray opened this issue Mar 11, 2020 · 2 comments

Comments

@CobaltGray
Copy link

CobaltGray commented Mar 11, 2020

When trying to compile on OSX 10.15.3 the compilation throws the error:

Build failed -> task in 'mt-c++' failed (exit status 1): {task 140367451013520: cxx ThreadGroup.cpp -> ThreadGroup.cpp.1.o} ['/usr/local/bin/g++', '-fPIC', '-std=c++11', '-Wall', '-Wno-deprecated-declarations', '-O3', '-m64', '-I/Users/darren/Development/six-library/target/externals/coda-oss/modules/c++/mt/include', '-I/Users/darren/Development/six-library/externals/coda-oss/modules/c++/mt/include', '-I/Users/darren/Development/six-library/externals/coda-oss/modules/c++/include', '-I/Users/darren/Development/six-library/target/externals/coda-oss/modules/c++/math/include', '-I/Users/darren/Development/six-library/externals/coda-oss/modules/c++/math/include', '-I/Users/darren/Development/six-library/target/externals/coda-oss/modules/c++/mem/include', '-I/Users/darren/Development/six-library/externals/coda-oss/modules/c++/mem/include', '-I/Users/darren/Development/six-library/target/externals/coda-oss/modules/c++/sys/include', '-I/Users/darren/Development/six-library/externals/coda-oss/modules/c++/sys/include', '-I/Users/darren/Development/six-library/target/externals/coda-oss/modules/c++/str/include', '-I/Users/darren/Development/six-library/externals/coda-oss/modules/c++/str/include', '-I/Users/darren/Development/six-library/target/externals/coda-oss/modules/c++/except/include', '-I/Users/darren/Development/six-library/externals/coda-oss/modules/c++/except/include', '-I/Users/darren/Development/six-library/target/externals/coda-oss/modules/c++/config/include', '-I/Users/darren/Development/six-library/externals/coda-oss/modules/c++/config/include', '-I/Users/darren/Development/six-library/target/externals/coda-oss/modules/c++/types/include', '-I/Users/darren/Development/six-library/externals/coda-oss/modules/c++/types/include', '-D_FILE_OFFSET_BITS=64', '-D_LARGEFILE_SOURCE', '-DSWIG_PYTHON_SILENT_MEMLEAK', '-DPYTHONDIR="/usr/local/lib/python2.7/site-packages"', '-DPYTHONARCHDIR="/usr/local/lib/python2.7/site-packages"', '-DHAVE_PYTHON_H=1', '-DNITF_DEFAULT_PLUGIN_PATH="/usr/local/share/nitf/plugins"', '-DDEFAULT_SCHEMA_PATH="/usr/local/conf/schema/six"', '-D_LARGEFILE_SOURCE=1', '-DSWIG_PYTHON_SILENT_MEMLEAK=1', '-DHAVE_PYTHON_H', '../externals/coda-oss/modules/c++/mt/source/ThreadGroup.cpp', '-c', '-o', 'externals/coda-oss/modules/c++/mt/source/ThreadGroup.cpp.1.o']

It looks like CPUAffinityInitializerLinux is not being defined. In ...mt/CPUAdffinityInitialiser.h :
`#include <mt/AbstractCPUAffinityInitializer.h>

#if defined(WIN32)
#include <mt/CPUAffinityInitializerWin32.h>
namespace mt
{
typedef CPUAffinityInitializerWin32 CPUAffinityInitializer;
}
#endif

#if !defined(APPLE_CC)
#if defined(__linux) || defined(linux)
#include <mt/CPUAffinityInitializerLinux.h>
namespace mt
{
typedef CPUAffinityInitializerLinux CPUAffinityInitializer;
}
#endif
#endif
`
so no define if using APPLE_CC

@JonathanMeans
Copy link
Contributor

Have you confirmed that this change works for you?

Supporting Mac is not a priority for us (and I don't have a way to test this in any case), but if you have a fix I can probably get it worked in.

@CobaltGray
Copy link
Author

No sorry couldn't get it working yet. There are more subtleties than just hacking #define loops around the lack of #ifdef APPLE_CC that defeated me.

kaydoh pushed a commit to kaydoh/six-library that referenced this issue Feb 9, 2022
d5dafc3 Merge pull request ngageoint#330 from mdaus/fix_sys_include
1bcac55 Remove sys_config.h include
c8713c2 Merge pull request ngageoint#329 from mdaus/fix_msvs
0921105 Only recurse into directories that exist
0efc30c Merge pull request ngageoint#328 from mdaus/require_cpp11
e0a488b Merge master to resolve conflicts
d41ee9b Merge pull request ngageoint#327 from mdaus/config_setup
87b1511 Fix indentation
d3a61e1 Always add c++11 flag
fe8b00f Re add sys check for C++11 for Windows
b961b5c Require C++11
b1df36b Remove unittest option
72eea9c add waf_unit_test switch
e6f9693 Pull out config module
4995c9e Merge pull request ngageoint#326 from mdaus/shared_drivers
e611f36 Don't write def file if it already exists
5bef0e4 Allow shared build of xml and zlib
a63d1bc Allow shared build of JPEG
521f4de Strip whitespace
eee482d Merge pull request ngageoint#325 from mdaus/fix_shared_build_linux
40e5608 Fix building shared libraries on Linux
7e0a53e Merge pull request ngageoint#324 from mdaus/waf-globdirwalker-py37
8f01613 Change 'raise StopIteration' in GlobDirectoryWalker to 'return'. Rationale in PEP479. Tested with Python 2.7.12 and 3.7.2.
eb2579d Merge pull request ngageoint#323 from mdaus/explicit_version_check
4378879 Add explicit Python version check
af16c43 Merge pull request ngageoint#322 from mdaus/range-touches-empty
24e75b3 Define touching as false if either of the ranges are empty
e7a026a Merge pull request ngageoint#320 from mdaus/add_python_agnostic_build_option
5b15de9 Add Python version-agnostic build option
d57fc0e Merge pull request ngageoint#319 from mdaus/run_python_unittests
7dbeb19 Fix error running Python unittests
5f463e5 Merge pull request ngageoint#318 from mdaus/install_python_unittests
d188d63 Make build.py install Python unittests as well
a4b7ae4 Merge pull request ngageoint#317 from mdaus/range-touches
447e6ec Updated comment
6e214eb Added 'touches' member function to Range. Allows for determining if two disjoint ranges can be placed next to one another with no gap between them
143fb21 Merge pull request ngageoint#316 from mdaus/check_swig_version
0196e37 Set minimum version for building CODA
af8c9bb Fail configuration if trying to use too-old SWIG

git-subtree-dir: externals/coda-oss
git-subtree-split: d5dafc385f90d9d0f614bd20cbe4054a1319c844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants