throw BadRequestException when a wrong operator set to a filter

ngabor84 · May 23, 2017 · e7708e4 · e7708e4
1 parent d1011aa
commit e7708e4
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/BuilderParamsApplierTrait.php b/src/BuilderParamsApplierTrait.php
@@ -7,6 +7,7 @@
 use LumenApiQueryParser\Params\Filter;
 use LumenApiQueryParser\Params\RequestParamsInterface;
 use LumenApiQueryParser\Params\Sort;
+use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 
 trait BuilderParamsApplierTrait
 {
@@ -70,7 +71,6 @@ protected function applyFilter(Builder $query, Filter $filter): void
                 $clauseOperator = 'LIKE';
                 break;
             case 'eq':
-            default:
                 $clauseOperator = '=';
                 break;
             case 'ne':
@@ -88,12 +88,12 @@ protected function applyFilter(Builder $query, Filter $filter): void
             case 'le':
                 $clauseOperator = '<=';
                 break;
+            default:
+                throw new BadRequestHttpException(sprintf('Not allowed operator: %s', $operator));
         }
 
         if ($operator === 'in') {
-            call_user_func_array([$query, 'whereIn'], [
-                $field, explode('|', $value)
-            ]);
+            $query->whereIn($filter, explode('|', $value));
         } else {
             call_user_func_array([$query, $method], [
                 $field, $clauseOperator, $value