Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split NODE_ENV to add an APP_ENV env var #123

Closed
nfroidure opened this issue Oct 4, 2021 · 0 comments · Fixed by #160
Closed

Split NODE_ENV to add an APP_ENV env var #123

nfroidure opened this issue Oct 4, 2021 · 0 comments · Fixed by #160
Milestone

Comments

@nfroidure
Copy link
Owner

nfroidure commented Oct 4, 2021

Issue

Actually,there is a confusion in the meaning of NODE_ENV that, in fact, have only 3 official values (test, development, production). It is, in fact, supposed to cover more or less what the DEV_MODE=1 env var actually does at the moment (see https://koistya.medium.com/demystifying-node-env-var-b25ed43c9af).

We should create a distinct APP_ENV variable that accept deployments environments like uat, staging ... and load the configurations from it instead of from the NODE_ENV value.

Simply use : https://github.com/nfroidure/application-services/tree/main/src/services

@nfroidure nfroidure modified the milestones: 4.0.0, 9.0.0 Oct 4, 2021
nfroidure added a commit to nfroidure/common-services that referenced this issue Aug 12, 2023
Refactoring while integrating with `whook`. See nfroidure/whook#123 .
nfroidure added a commit to nfroidure/application-services that referenced this issue Aug 12, 2023
Refactoring while integrating with `whook`. See nfroidure/whook#123 .
nfroidure added a commit to nfroidure/application-services that referenced this issue Aug 12, 2023
Refactoring while integrating with `whook`. See nfroidure/whook#123 .
nfroidure added a commit that referenced this issue Aug 12, 2023
Integrating new `application-services` fix #123 .
nfroidure added a commit to nfroidure/application-services that referenced this issue Aug 15, 2023
Refactoring while integrating with `whook`. See nfroidure/whook#123 .
nfroidure added a commit to nfroidure/common-services that referenced this issue Aug 15, 2023
Refactoring while integrating with `whook`. See nfroidure/whook#123 .
nfroidure added a commit that referenced this issue Aug 16, 2023
Integrating new `application-services` fix #123 .
nfroidure added a commit that referenced this issue Aug 16, 2023
Integrating new `application-services` fix #123 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant