fix(compile): avoid direct import of dev deps

nfroidure · Sep 25, 2021 · 8db9dbe · 8db9dbe
1 parent 70a8387
commit 8db9dbe
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/packages/whook/src/services/compiler.test.ts b/packages/whook/src/services/compiler.test.ts
@@ -1,5 +1,6 @@
 import path from 'path';
 import * as esbuild from 'esbuild';
+import * as esbuildNodeExternals from 'esbuild-node-externals';
 import initCompiler from './compiler';
 
 describe('Compiler', () => {
@@ -17,7 +18,8 @@ describe('Compiler', () => {
   });
 
   test('should work with external modules', async () => {
-    importer.mockResolvedValue(esbuild);
+    importer.mockResolvedValueOnce(esbuild);
+    importer.mockResolvedValueOnce(esbuildNodeExternals);
 
     const compiler = await initCompiler({
       PROJECT_DIR,
@@ -37,15 +39,16 @@ describe('Compiler', () => {
       logCalls: log.mock.calls,
     }).toMatchInlineSnapshot(`
       Object {
-        "contentsLength": 121905,
+        "contentsLength": 90265,
         "logCalls": Array [],
         "mappingsLength": 0,
       }
     `);
   });
 
   test('should work with code only', async () => {
-    importer.mockResolvedValue(esbuild);
+    importer.mockResolvedValueOnce(esbuild);
+    importer.mockResolvedValueOnce(esbuildNodeExternals);
 
     const compiler = await initCompiler({
       PROJECT_DIR,
@@ -65,7 +68,7 @@ describe('Compiler', () => {
       logCalls: log.mock.calls,
     }).toMatchInlineSnapshot(`
       Object {
-        "contentsLength": 5066,
+        "contentsLength": 5024,
         "logCalls": Array [],
         "mappingsLength": 0,
       }

diff --git a/packages/whook/src/services/compiler.ts b/packages/whook/src/services/compiler.ts
@@ -1,7 +1,6 @@
 import path from 'path';
 import { noop } from '../libs/utils';
 import { autoService } from 'knifecycle';
-import { nodeExternalsPlugin } from 'esbuild-node-externals';
 import type { LogService } from 'common-services';
 import type { BuildOptions } from 'knifecycle/dist/build';
 import type { ImporterService } from '..';
@@ -52,6 +51,7 @@ async function initCompiler({
   log = noop,
 }: WhookCompilerDependencies): Promise<WhookCompilerService> {
   const { build } = await importer('esbuild');
+  const { nodeExternalsPlugin } = await importer('esbuild-node-externals');
 
   return async function compiler(
     entryPoint: string,