Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps to latest version #43

Merged
merged 4 commits into from
Mar 18, 2021
Merged

Update deps to latest version #43

merged 4 commits into from
Mar 18, 2021

Conversation

j0k3r
Copy link
Contributor

@j0k3r j0k3r commented Mar 18, 2021

Add Node 12 & 14 in Travis.

Here are the missing one (for now):

$ npm outdated
Package                 Current  Wanted  Latest  Location
eslint                   5.16.0  5.16.0  7.22.0  bestzip
eslint-config-prettier    4.3.0   4.3.0   8.1.0  bestzip
prettier                 1.19.1  1.19.1   2.2.1  bestzip

nfriedly
nfriedly reviewed Mar 18, 2021
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
nfriedly
nfriedly reviewed Mar 18, 2021
View reviewed changes
package.json
@@ -21,24 +21,24 @@
"lib/"
],
"dependencies": {
"archiver": "^4.0.2",
"archiver": "^5.3.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what changed between archiver 4 and 5?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Dropped Node < 10
  • Use of readdir-glob instead of glob be memory efficient

And some deps updated

@nfriedly
Copy link
Owner

Hey @j0k3r, thanks for this!

I think it's mostly good, although since bestzip is pretty heavily dependent on archiver, I do want to know if whatever constituted a breaking change in archiver should also be published as a breaking change here.

eslint and friends can also be updated, although that might necessitate an increase in the minimum node.js version that we test against. ESLint tends to be pretty aggressive about adopting new node.js features.

@j0k3r
Copy link
Contributor Author

j0k3r commented Mar 18, 2021

The only breaking change from archiver is archiverjs/node-archiver#433:

absolute glob patterns are not supported: archiver.glob('*.txt',{cwd: '/tmp'}) has to be used instead of archiver.glob('/tmp/*.txt')

But I don't think it affects bestzip.

About ESLint, for now there are sill allowing Node 10:

Prerequisites: Node.js (^10.12.0, or >=12.0.0)

I'll work on upgrading ESLint and their friends too

j0k3r added 2 commits March 18, 2021 16:19
@j0k3r
Update ESLint and their friends
e04faea 
A lot of files changed following these update.

One manual fix was to add `"use strict";` in `.eslintrc.js` file because of:

```
/Users/j0k/Sites/github/node-bestzip/.eslintrc.js
  1:1  error  Use the global form of 'use strict'  strict

/Users/j0k/Sites/github/node-bestzip/bin/.eslintrc.js
  1:1  error  Use the global form of 'use strict'  strict

/Users/j0k/Sites/github/node-bestzip/test/.eslintrc.js
  1:1  error  Use the global form of 'use strict'  strict
```

Also:
- revert previous changes in Travis.
- add a minimum node version (>=10)
@j0k3r
Fix prettier error in windows
1e93f6e 
Which was `error  Delete `␍`  prettier/prettier`
@j0k3r j0k3r requested a review from nfriedly March 18, 2021 15:33
nfriedly
nfriedly reviewed Mar 18, 2021
View reviewed changes
.eslintrc.js
"prettier/prettier": [
"error",
{
endOfLine: "auto",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL! 'auto' seems fine for now.

nfriedly
nfriedly approved these changes Mar 18, 2021
View reviewed changes
Copy link
Owner

@nfriedly nfriedly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks!

@nfriedly nfriedly merged commit 6f7d98e into nfriedly:master Mar 18, 2021
@nfriedly
Copy link
Owner

Should be published as v2.2.0 shortly

@j0k3r j0k3r deleted the update-deps branch March 18, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfriedly nfriedly nfriedly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j0k3r @nfriedly