Don't allow apostrophe in URLs (#499)

Fixes #488, should end URL if encountered.
nfrasser · Dec 4, 2024 · a7629c2 · a7629c2
1 parent b72c682
commit a7629c2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/packages/linkifyjs/src/parser.mjs b/packages/linkifyjs/src/parser.mjs
@@ -50,7 +50,6 @@ export function init({ groups }) {
 	// but cannot be the very last characters
 	// Characters that cannot appear in the URL at all should be excluded
 	const qsNonAccepting = [
-		tk.APOSTROPHE,
 		tk.COLON,
 		tk.COMMA,
 		tk.DOT,

diff --git a/test/spec/linkifyjs/parser.test.mjs b/test/spec/linkifyjs/parser.test.mjs
@@ -243,9 +243,9 @@ const tests = [
 	],
 	['"https://surrounded.by.quotes/"', [Text, Url, Text], ['"', 'https://surrounded.by.quotes/', '"']],
 	[
-		"More weird character in http://facebook.com/#aZ?/:@-._~!$&'()*+,;= that Url",
+		'More weird character in http://facebook.com/#aZ?/:@-._~!$&()*+,;= that Url',
 		[Text, Url, Text],
-		['More weird character in ', "http://facebook.com/#aZ?/:@-._~!$&'()*+,;=", ' that Url'],
+		['More weird character in ', 'http://facebook.com/#aZ?/:@-._~!$&()*+,;=', ' that Url'],
 	],
 	[
 		'Email with a underscore is n_frasser@example.xyz asd',
@@ -262,6 +262,11 @@ const tests = [
 		[Text, Url, Text],
 		["A link in '", 'singlequote.club/wat', "' extra fluff at the end"],
 	],
+	[
+		"I really like http://singlequote.club's website design",
+		[Text, Url, Text],
+		['I really like ', 'http://singlequote.club', "'s website design"],
+	],
 	[
 		'Email with mailsomething dot com domain in foo@mailsomething.com',
 		[Text, Email],