New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception message when invalid matching. #29

Merged

nfedyashev merged 1 commit into nfedyashev:master from msroz:fix_matching_exception_msg

Feb 20, 2019

+7 −1

msroz commented Feb 20, 2019

exception message is a bit confusing for developer when option matching is invalid type.

exception message is following:

 #=> :matches must be a string or regex (ArgumentError)

it is a bit confusing because of no matches options.

Retryable.retryable(
  matching: 1 # invalid type
) do |retries, exception|
  raise StandardError, "test"
end


          Fix exception message when invalid matching.

371f50c

nfedyashev merged commit de52b32 into nfedyashev:master

Owner

nfedyashev commented Feb 20, 2019

@msroz thanks for noticing! Good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet