Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SatisfiesPredicate to Validate.Param and Validate.ParamCollection #91

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

LibraChris
Copy link
Contributor

Introduce SatisfiesParameter as a validation method for Param and ParamCollection, alongside foundational tests for both functionalities.

LibraChris and others added 3 commits March 1, 2024 15:11
Add SatisfiesPredicate for Validation for Param and ParamCollection
Add StatisfiedPredicate Tests
@omaus
Copy link
Collaborator

omaus commented Mar 21, 2024

Could it be that Validate.ParamCollection.SatisfiesParameter is the same like the function in this PR?: #88 🤔

@LibraChris
Copy link
Contributor Author

Could it be that Validate.ParamCollection.SatisfiesParameter is the same like the function in this PR?: #88 🤔

No, since your function checks each element against a condition, while mine just checks if a certain function on the Params returns true. So, for example, using Seq.exist would return true if just one element of the ParamCollection matches.

@omaus
Copy link
Collaborator

omaus commented Mar 22, 2024

Could it be that Validate.ParamCollection.SatisfiesParameter is the same like the function in this PR?: #88 🤔

Could it be that Validate.ParamCollection.SatisfiesParameter is the same like the function in this PR?: #88 🤔

No, since your function checks each element against a condition, while mine just checks if a certain function on the Params returns true. So, for example, using Seq.exist would return true if just one element of the ParamCollection matches.

Ah okay, I get it. Thx! 👍

Add validation_prototype
@kMutagene
Copy link
Member

Let's incorporate the spec validation directly into the lib, after dependency updates and this is merged 👍

@kMutagene kMutagene merged commit b283580 into nfdi4plants:main Apr 19, 2024
2 checks passed
@kMutagene kMutagene changed the title Add SatisfiesParameter to Validate.Param and Validate.ParamCollection Add SatisfiesPredicate to Validate.Param and Validate.ParamCollection Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants