drug selector #38
Merged
drug selector #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaybee84
requested changes
Jul 16, 2020
There was a problem hiding this comment.
Looks really nice! and Yay! kairos is live!
Couple of things are not working as expected:
- The "Most Variable LV" plot is not rendering (likely due to the server-side dependencies)
- Select cellLines tab is not letting me uncheck all checkboxes (specifically for nf1 and nf2 checkboxes, I cant uncheck +/+ and unknown), is this by design?
- If I add more than cisplatin in the select drugs tab, only cisplatin is being plotted in the dose-response tab (wondering if it is due to demo data restrictions)
- The top plot in the dose-response tab is not rendering (not sure why)
Also, wondering if it makes sense to combine 'select cell line' and 'select drug' tabs into one "Selection" tab since both of them have a lot of empty real estate :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic drug selection module. This branch is live! https://shiny.synapse.org/users/rallaway/kairos/
Check it out and let me know if you have any feedback. I'd like to merge this soon because develop has started to get ahead of this branch in some places.